Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/commands: Add desc as an alias for description #2282

Merged
merged 1 commit into from
Sep 21, 2023
Merged

cli/commands: Add desc as an alias for description #2282

merged 1 commit into from
Sep 21, 2023

Conversation

honglooker
Copy link
Collaborator

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

martinvonz
martinvonz approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me. It doesn't seem like it would conflict with any future commands, and I don't think aliases make any difference when it comes to shell completion (at least not for Fish). Let's give others a chance to comment, though.

PhilipMetzger
PhilipMetzger approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, I have no issue with this alias.

cli/src/commands/mod.rs Show resolved Hide resolved
@honglooker honglooker changed the title Add desc as an alias for description cli/commands: Add desc as an alias for description Sep 21, 2023
@martinvonz
Copy link
Member

LG, I have no issue with this alias.

Alright, that's good enough for me. Feel free to merge, @honglooker. Worst case we roll it back :)

@honglooker honglooker merged commit a736c15 into main Sep 21, 2023
15 checks passed
@honglooker honglooker deleted the hong/add-desc branch September 21, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipMetzger PhilipMetzger PhilipMetzger approved these changes

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honglooker @martinvonz @PhilipMetzger