Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: make jj installable with cargo binstall #2278

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

ilyagr
Copy link
Collaborator

@ilyagr ilyagr commented Sep 20, 2023

(This is mainly a draft because it is based on #2277)

https://github.com/cargo-bins/cargo-binstall

Note that jj will only become installable once the next release
is published to crates.io. For this reason, I am planning to
wait until then before documenting the fact that jj can be
installed this way.

At that point, cargo binstall jj-cli should be sufficient.

Before then, it's possible to test that this will work by doing

cargo binstall jj-cli --force --strategies crate-meta-data \
   --log-level debug  --dry-run --manifest-path cli/Cargo.toml

Without --dry-run, this should install the 0.9 release if run
on cli/Cargo.toml form this commit. (You don't need the rest
of the jj repo for this to work, you can just download the
Cargo.toml and point --manifest-path to it)

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@ilyagr ilyagr force-pushed the binstall branch 2 times, most recently from 078aa2f to a258e58 Compare September 20, 2023 06:24
https://github.com/cargo-bins/cargo-binstall

Note that `jj` will only become installable once the next release
is published to crates.io. For this reason, I am planning to
wait until then before documenting the fact that `jj` can be
installed this way.

At that point, `cargo binstall jj-cli` should be sufficient.

Before then, it's possible to test that this will work by doing

```
cargo binstall jj-cli --force --strategies crate-meta-data --log-level debug  --dry-run --manifest-path cli/Cargo.toml
``` 

Without --dry-run, this should install the 0.9 release if run
on `cli/Cargo.toml` form this commit.
@ilyagr ilyagr marked this pull request as ready for review September 20, 2023 16:06
@ilyagr ilyagr merged commit 86767e4 into jj-vcs:main Sep 20, 2023
15 checks passed
@ilyagr ilyagr deleted the binstall branch September 20, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants