Use an enum for backend to use in tests #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-untysktpqvzy
branch
from
7cc3328 to
9c475c5
Compare
yuja
approved these changes
Sep 18, 2023
I don't think there's much reason to run most tests with a `.git` directory outside of `.jj`. I think it's just that way for historical reasons. It's been that way since I added support for `.jj`-internal repos in a8a9f7d. The reason I want to switch is to make it a little easier to create test repos for different backends. The problem with `.jj`-external git repos is that they depend on an additional path. I had to update `test_bad_locking.rs` to make the code merging directories able handle missing directories on some side, because git's loose objects result in directories getting created on one or both sides.
I plan to add another backend for use in tests.
It makes the call sites clearer if we pass the `TestRepoBackend` enum instead of the boolean `use_git` value. It's also more extensible (I plan to add another backend for tests).
martinvonz
force-pushed
the
push-uxrkylpovoym
branch
from
0b24a17 to
a200b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md