Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: rename jj-docs-bot to jj-docs[bot] #2261

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

ilyagr
Copy link
Collaborator

@ilyagr ilyagr commented Sep 16, 2023

Perhaps this will stop Github from showing jj-docs-bot as a very active contributor in https://github.com/martinvonz/jj/pulse. This would probably fair, even though jj-docs-bot tries its best to be a good and helpful bot.

Regardless, this seems to be the standard on Github which has dependabot[bot] and github-actions[bot].


Let me know if you want me to test this on my own repo before merging. There's a small chance this could break jj-docs[bot] somehow, but I doubt it, and it'd be obvious immediately if it did break (as the docs would immediately fail to build).

@ilyagr ilyagr marked this pull request as ready for review September 16, 2023 01:38
@ilyagr ilyagr marked this pull request as draft September 16, 2023 01:40
Perhaps this will stop Github from showing jj-docs-bot as a very active
contributor in https://github.com/martinvonz/jj/pulse. This would
probably fair, even though jj-docs-bot tries its best to be a good and
helpful bot.

Regardless, this seems to be the standard on Github which has
`dependabot[bot]` and `github-actions[bot]`.
@ilyagr ilyagr marked this pull request as ready for review September 16, 2023 01:41
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's see if it helps.

@ilyagr ilyagr merged commit f31e66d into jj-vcs:main Sep 16, 2023
15 checks passed
@ilyagr ilyagr deleted the jj-docs-bot branch September 16, 2023 02:31
@ilyagr
Copy link
Collaborator Author

ilyagr commented Sep 19, 2023

As far as https://github.com/martinvonz/jj/pulse is concerned, this did not help. jj-docs[bot] just passed jj-docs-bot in terms of productivity. Oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants