repo_path: avoid repeated copying of PathBuf in to_fs_path()
#2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
approved these changes
Sep 9, 2023
I've noticed `WorkspaceCommandHelper::format_file_path()` appear in profiles a few times. A big part of that is spent in `RepoPath::to_fs_path()`. I think I had been thinking that `PathBuf::join()` takes `self` by value and mutates it, but it turns out it creates a new instance. So our `result = result.join(...)` in a loop was copying the `PathBuf` over and over. This fixes that and also reserves the expected size. That speeds up `jj files --ignore-working-copy -r v6.0` in the Linux repo from 546.0 s to 509.3 s (6.7%).
martinvonz
force-pushed
the
push-nvwyytpwrtmk
branch
from
6f1d3a4 to
6a853ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md