cli: re-enable 'watchman' support when 'packaging' is enabled #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 70f6e0a enabled watchman by default in the *default* features set, but removed it from the 'packaging' set. But features are not 'additive' by default. When building the Nix flake from this repository, it uses --features packaging, which no longer enables watchman, because it was removed. The easiest solution is probably just to ensure 'packaging' is always a superset of 'default', but I'm not sure of a way to do this. Signed-off-by: Austin Seipp <[email protected]> Change-Id: Ia31d5b98e0324a2b19014a3cae25672d
|
I thought features were additive. Oh, could the real reason I broke it be that the Nix flake disables default features? Could you update the description if you agree with that? |
|
Oh, I missed that too. I can fix that, yeah. |
|
Actually, just fixing this in the Flake is, IMO, better. I'll just abandon this and put up that patch, instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: 70f6e0a enabled watchman by default in the default features set, but removed it from the 'packaging' set. But features are not 'additive' by default. When building the Nix flake from this repository, it uses --features packaging, which no longer enables watchman, because it was removed.
The easiest solution is probably just to ensure 'packaging' is always a superset of 'default', but I'm not sure of a way to do this.