Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: enable the watchman feature by default #2234

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

martinvonz
Copy link
Member

@martinvonz martinvonz commented Sep 8, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

I think the feature is requested by enough users that we should
include it by default, also for people who install from source (we
include it in the `packaging` feature already).

It increases the size of the binary from 16.5 MiB to 17.8 MiB. I
suspect we'd see some of that increase in size soon anyway, as I'm
probably going to use Tokio for making async backend requests.
@martinvonz martinvonz requested a review from arxanas September 8, 2023 13:19
@martinvonz martinvonz merged commit 70f6e0a into main Sep 8, 2023
15 checks passed
@martinvonz martinvonz deleted the push-lssmkprllzyn branch September 8, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants