Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: add method to import commits, promote them to tree-conflict format #2232

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Sep 8, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 4 commits September 8, 2023 19:28
…hod call

The main goal of this change is to enable tree-level conflict format, but it
also allows us to bulk-import commits on clone/init. I think a separate method
will help if we want to provide progress information, enable check for
.jjconflict entries under certain condition, etc.

Since git::import_refs() now depends on GitBackend type, it might be better to
remove git_repo from the function arguments.
Since we now have an explicit method to import heads, it makes more sense to
manage no-gc refs by the backend.
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

lib/src/git_backend.rs Show resolved Hide resolved
lib/src/git.rs Show resolved Hide resolved
@yuja yuja merged commit d05aaf3 into jj-vcs:main Sep 8, 2023
15 checks passed
@yuja yuja deleted the push-srpouxompsrq branch September 8, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants