Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: split export_some_refs() to smaller functions #2207

Merged
merged 6 commits into from
Sep 5, 2023
Merged

git: split export_some_refs() to smaller functions #2207

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a5669a
git: remove stale TODO comment about FailedRefExportReason
yuja Sep 5, 2023
5399677
git: extract helper that exports single deleted ref
yuja Sep 5, 2023
c2c8595
git: extract helper that exports single updated ref
yuja Sep 5, 2023
a1051bd
git: do not export new ref if racy process created one with the same …
yuja Sep 5, 2023
3dbc106
git: extract calculation step from export_some_refs()
yuja Sep 5, 2023
beea985
git: rename local variables in diff_refs_to_export()
yuja Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/src/git.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,6 @@ pub enum FailedRefExportReason {
/// We do not export tags and other refs at the moment, since these aren't
/// supposed to be modified by JJ. For them, the Git state is considered
/// authoritative.
// TODO: Also indicate why we failed to export these branches
martinvonz marked this conversation as resolved.
Show resolved Hide resolved
pub fn export_refs(
mut_repo: &mut MutableRepo,
git_repo: &git2::Repository,
Expand Down