Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: support path arguments to jj commit #2132

Merged
merged 2 commits into from
Oct 1, 2023
Merged

commands: support path arguments to jj commit #2132

merged 2 commits into from
Oct 1, 2023

Conversation

arxanas
Copy link
Collaborator

@arxanas arxanas commented Aug 22, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@arxanas arxanas changed the base branch from arxanas/commit-1 to arxanas/split-3 August 23, 2023 04:20
@arxanas arxanas force-pushed the arxanas/commit-2 branch 3 times, most recently from a5ed82e to e6b833d Compare August 27, 2023 15:43
@arxanas arxanas force-pushed the arxanas/split-3 branch 2 times, most recently from 77972af to a4de44f Compare August 29, 2023 21:13
@arxanas arxanas force-pushed the arxanas/commit-2 branch 2 times, most recently from 0cdb550 to dd8467c Compare August 30, 2023 08:55
@arxanas arxanas marked this pull request as ready for review August 31, 2023 16:28
@arxanas arxanas force-pushed the arxanas/commit-2 branch 2 times, most recently from 2fd80ab to 7efa03c Compare September 18, 2023 01:35
@arxanas arxanas marked this pull request as draft September 19, 2023 04:59
@arxanas arxanas marked this pull request as ready for review September 20, 2023 18:55
martinvonz
martinvonz reviewed Sep 20, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@martinvonz martinvonz mentioned this pull request Sep 20, 2023
Merged
4 tasks
Base automatically changed from arxanas/split-3 to arxanas/split-2 September 21, 2023 01:30
Base automatically changed from arxanas/split-2 to main September 25, 2023 00:48
@arxanas
commands: add --interactive flag to jj split
0ef992e 
`jj split` with no arguments operates interactively, but I am nonetheless constantly running `jj split -i` because I expect an `--interactive` flag to exist for consistency.

However, `jj split <paths>` before this commit always operates non-interactively, so this commit has the nice practical effect that you can restrict your interactive splitting to a certain set of paths.
@arxanas
commands: support path arguments to jj commit
82880b9
@arxanas arxanas enabled auto-merge (rebase) October 1, 2023 02:28
@arxanas arxanas merged commit 946a6e0 into main Oct 1, 2023
15 checks passed
@arxanas arxanas deleted the arxanas/commit-2 branch October 1, 2023 02:45
@arxanas arxanas linked an issue Nov 10, 2023 that may be closed by this pull request
FR: commit only a certain path or directory, or exclude some changes from commit, also, allow status to reflect changes in a path or directory #2393
Open
@arxanas arxanas mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arxanas @martinvonz