Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_tools: reorder editor_args_from_settings #2119

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

arxanas
Copy link
Collaborator

@arxanas arxanas commented Aug 19, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@arxanas arxanas force-pushed the arxanas/difftool-3 branch from b5b160c to befefab Compare August 21, 2023 00:20
@arxanas arxanas force-pushed the arxanas/difftool-4 branch from 6e3bfd3 to d13a99e Compare August 21, 2023 00:20
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from befefab to e932658 Compare August 21, 2023 03:57
@arxanas arxanas force-pushed the arxanas/difftool-4 branch from d13a99e to 8fd121a Compare August 21, 2023 03:57
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from e932658 to 18b3d7a Compare August 22, 2023 04:34
@arxanas arxanas force-pushed the arxanas/difftool-4 branch from 8fd121a to aa8f576 Compare August 22, 2023 04:34
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from 18b3d7a to b522168 Compare August 23, 2023 04:20
@arxanas arxanas force-pushed the arxanas/difftool-4 branch from aa8f576 to 9f8c312 Compare August 23, 2023 04:20
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge_tools: reorder editor_args_from_settings

Could you update the description to say why? (I'm guessing it's that you prefer to define functions before functions that depend on them.)

@arxanas arxanas force-pushed the arxanas/difftool-3 branch from b522168 to d69c2f1 Compare August 27, 2023 13:49
@arxanas arxanas force-pushed the arxanas/difftool-4 branch 3 times, most recently from ddf1a50 to ec1ff78 Compare August 27, 2023 15:43
@arxanas arxanas force-pushed the arxanas/difftool-3 branch from 875c24f to f5426d2 Compare August 29, 2023 21:13
@arxanas arxanas force-pushed the arxanas/difftool-4 branch 2 times, most recently from 3e28863 to 6a50295 Compare August 30, 2023 08:55
@arxanas arxanas force-pushed the arxanas/difftool-3 branch 2 times, most recently from c2dde80 to b604a2d Compare August 31, 2023 16:29
@arxanas arxanas force-pushed the arxanas/difftool-4 branch from 6a50295 to 7ca170f Compare August 31, 2023 16:29
Base automatically changed from arxanas/difftool-3 to main September 18, 2023 04:33
The rest of the functions in this file are defined before they are used, so it confused me when trying to track down this function in the static call graph.
@arxanas arxanas enabled auto-merge (rebase) September 19, 2023 04:58
@arxanas arxanas merged commit 742df27 into main Sep 19, 2023
15 checks passed
@arxanas arxanas deleted the arxanas/difftool-4 branch September 19, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants