fix: address review feedback

jj-vcs · May 9, 2024 · cc863df · cc863df
1 parent e4e6c23
commit cc863df
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/cli/src/commands/git.rs b/cli/src/commands/git.rs
@@ -220,7 +220,7 @@ pub struct GitPushArgs {
     /// correspond to missing local branches.
     #[arg(long)]
     deleted: bool,
-    /// Push branches that contain empty descriptions
+    /// Push branches with commits that contain empty descriptions
     #[arg(long)]
     allow_empty_description: bool,
     /// Push branches pointing to these commits (can be repeated)

diff --git a/cli/tests/[email protected] b/cli/tests/[email protected]
@@ -930,7 +930,7 @@ By default, pushes any branches pointing to `remote_branches(remote=<remote>)..@
 
   Possible values: `true`, `false`
 
-* `--allow-empty-description` — Push branches that contain empty descriptions
+* `--allow-empty-description` — Push branches with commits that contain empty descriptions
 
   Possible values: `true`, `false`
 

diff --git a/cli/tests/test_git_push.rs b/cli/tests/test_git_push.rs
@@ -642,13 +642,6 @@ fn test_git_push_no_description() {
     insta::assert_snapshot!(stderr, @r###"
     Error: Won't push commit 5b36783cd11c since it has no description
     "###);
-}
-
-#[test]
-fn test_git_allow_push_no_description() {
-    let (test_env, workspace_root) = set_up();
-    test_env.jj_cmd_ok(&workspace_root, &["branch", "create", "my-branch"]);
-    test_env.jj_cmd_ok(&workspace_root, &["describe", "-m="]);
     test_env.jj_cmd_ok(
         &workspace_root,
         &[