Skip to content

Commit

Permalink
cli: drop redundant test of ancestor merge
Browse files Browse the repository at this point in the history
We now have lots of tests of ancestor merges in `test_bug_2600()`, so
we don't need the ones in `test_basics()`. Since it doesn't have the
"nottherootcommit" commit, it would break when we change the default
to preserve ancestor merges.
  • Loading branch information
martinvonz committed Feb 17, 2024
1 parent 30cbc2a commit ad5bbe0
Showing 1 changed file with 4 additions and 26 deletions.
30 changes: 4 additions & 26 deletions cli/tests/test_abandon_command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,28 +93,6 @@ fn test_basics() {
◉ [zzz]
"###);

// Abandoning `a` would normally result in its descendant merge commit, `e`,
// still having two parents. However, since one of those parents (the root
// commit) would be the ancestor of another, only one of the parents is kept.
test_env.jj_cmd_ok(&repo_path, &["undo"]);
let (stdout, stderr) = test_env.jj_cmd_ok(&repo_path, &["abandon", "a"]);
insta::assert_snapshot!(stdout, @"");
insta::assert_snapshot!(stderr, @r###"
Abandoned commit rlvkpnrz 2443ea76 a | a
Rebased 2 descendant commits onto parents of abandoned commits
Working copy now at: znkkpsqq b0af79c3 e | e
Parent commit : vruxwmqv b7c62f28 d | d
Added 0 files, modified 0 files, removed 1 files
"###);
insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###"
@ [znk] e
◉ [vru] d
◉ [roy] c
│ ◉ [zsu] b
├─╯
◉ [zzz] a
"###);

test_env.jj_cmd_ok(&repo_path, &["undo"]);
let (stdout, stderr) = test_env.jj_cmd_ok(&repo_path, &["abandon", "descendants(c)"]);
insta::assert_snapshot!(stdout, @"");
Expand All @@ -123,12 +101,12 @@ fn test_basics() {
znkkpsqq 5557ece3 e | e
vruxwmqv b7c62f28 d | d
royxmykx fe2e8e8b c | c
Working copy now at: wvuyspvk 3f93e69f (empty) (no description set)
Working copy now at: xtnwkqum e7bb0612 (empty) (no description set)
Parent commit : rlvkpnrz 2443ea76 a e?? | a
Added 0 files, modified 0 files, removed 3 files
"###);
insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###"
@ [wvu]
@ [xtn]
│ ◉ [zsu] b
├─╯
◉ [rlv] a e??
Expand Down Expand Up @@ -162,12 +140,12 @@ fn test_basics() {
vruxwmqv b7c62f28 d | d
zsuskuln 1394f625 b | b
rlvkpnrz 2443ea76 a | a
Working copy now at: oupztwtk 304ae338 (empty) (no description set)
Working copy now at: xlzxqlsl af874bff (empty) (no description set)
Parent commit : zzzzzzzz 00000000 a b e?? | (empty) (no description set)
Added 0 files, modified 0 files, removed 4 files
"###);
insta::assert_snapshot!(get_log_output(&test_env, &repo_path), @r###"
@ [oup]
@ [xlz]
│ ◉ [roy] c d e??
├─╯
◉ [zzz] a b e??
Expand Down

0 comments on commit ad5bbe0

Please sign in to comment.