Skip to content

Commit

Permalink
cli: add another test for snapshot.max-new-file-size
Browse files Browse the repository at this point in the history
This one just tests with a larger value and a human-readable string (10KB).

Signed-off-by: Austin Seipp <[email protected]>
Change-Id: If9e5d62146b369d3a1b7efe4e56a1b6b4338c720
  • Loading branch information
thoughtpolice committed Apr 4, 2024
1 parent fd3667e commit 83df19b
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions cli/tests/test_working_copy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ fn test_snapshot_large_file() {
test_env.jj_cmd_ok(test_env.env_root(), &["init", "repo", "--git"]);
let repo_path = test_env.env_root().join("repo");

// test a small file using raw-integer-literal syntax, which is interpreted
// in bytes
test_env.add_config(r#"snapshot.max-new-file-size = 10"#);
std::fs::write(repo_path.join("large"), "a lot of text").unwrap();
let stderr = test_env.jj_cmd_failure(&repo_path, &["files"]);
Expand All @@ -34,4 +36,21 @@ fn test_snapshot_large_file() {
- Run `jj --config-toml 'snapshot.max-new-file-size="13B"' st`
This will increase the maximum file size allowed for new files, for this command only.
"###);

// test with a larger file using 'KB' human-readable syntax
test_env.add_config(r#"snapshot.max-new-file-size = "10KB""#);
let big_string = vec![0; 1024 * 11];
std::fs::write(repo_path.join("large"), big_string).unwrap();
let stderr = test_env.jj_cmd_failure(&repo_path, &["files"]);
insta::assert_snapshot!(stderr, @r###"
Error: Failed to snapshot the working copy
The file '$TEST_ENV/repo/large' is too large to be snapshotted (11264 bytes).
The maximum size allowed is 10240 bytes.
Hint: This is to prevent large files from being added on accident. You can fix this error by:
- Adding the file to `.gitignore`
- Run `jj config set --repo snapshot.max-new-file-size "11264B"`
This will increase the maximum file size allowed for new files, in this repository only.
- Run `jj --config-toml 'snapshot.max-new-file-size="11264B"' st`
This will increase the maximum file size allowed for new files, for this command only.
"###);
}

0 comments on commit 83df19b

Please sign in to comment.