-
Notifications
You must be signed in to change notification settings - Fork 357
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sign: Implement a test signing backend and add a few basic tests
- Loading branch information
Showing
10 changed files
with
272 additions
and
11 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,171 @@ | ||
| use jj_lib::backend::{MillisSinceEpoch, Signature, Timestamp}; | ||
| use jj_lib::repo::Repo; | ||
| use jj_lib::settings::UserSettings; | ||
| use jj_lib::signing::{SigStatus, SignBehavior, Signer, Verification}; | ||
| use test_case::test_case; | ||
| use testutils::test_signing_backend::TestSigningBackend; | ||
| use testutils::{create_random_commit, write_random_commit, TestRepoBackend, TestWorkspace}; | ||
|
|
||
| fn user_settings(sign_all: bool) -> UserSettings { | ||
| let config = testutils::base_config() | ||
| .add_source(config::File::from_str( | ||
| &format!( | ||
| r#" | ||
| signing.key = "impeccable" | ||
| signing.sign-all = {sign_all} | ||
| "# | ||
| ), | ||
| config::FileFormat::Toml, | ||
| )) | ||
| .build() | ||
| .unwrap(); | ||
| UserSettings::from_config(config) | ||
| } | ||
|
|
||
| fn someone_else() -> Signature { | ||
| Signature { | ||
| name: "Someone Else".to_string(), | ||
| email: "[email protected]".to_string(), | ||
| timestamp: Timestamp { | ||
| timestamp: MillisSinceEpoch(0), | ||
| tz_offset: 0, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| fn good_verification() -> Option<Verification> { | ||
| Some(Verification { | ||
| status: SigStatus::Good, | ||
| key: Some("impeccable".to_owned()), | ||
| display: None, | ||
| }) | ||
| } | ||
|
|
||
| #[test_case(TestRepoBackend::Local ; "local backend")] | ||
| #[test_case(TestRepoBackend::Git ; "git backend")] | ||
| fn manual(backend: TestRepoBackend) { | ||
| let settings = user_settings(true); | ||
|
|
||
| let signer = Signer::new(Some(Box::new(TestSigningBackend)), vec![]); | ||
| let test_workspace = TestWorkspace::init_with_backend_and_signer(&settings, backend, signer); | ||
|
|
||
| let repo = &test_workspace.repo; | ||
|
|
||
| let settings = settings.clone(); | ||
| let repo = repo.clone(); | ||
| let mut tx = repo.start_transaction(&settings, "test"); | ||
| let commit1 = create_random_commit(tx.mut_repo(), &settings) | ||
| .set_sign_behavior(SignBehavior::Own) | ||
| .write() | ||
| .unwrap(); | ||
| let commit2 = create_random_commit(tx.mut_repo(), &settings) | ||
| .set_sign_behavior(SignBehavior::Own) | ||
| .set_author(someone_else()) | ||
| .write() | ||
| .unwrap(); | ||
| tx.commit(); | ||
|
|
||
| let commit1 = repo.store().get_commit(commit1.id()).unwrap(); | ||
| assert_eq!(commit1.verification().unwrap(), good_verification()); | ||
|
|
||
| let commit2 = repo.store().get_commit(commit2.id()).unwrap(); | ||
| assert_eq!(commit2.verification().unwrap(), None); | ||
| } | ||
|
|
||
| #[test_case(TestRepoBackend::Git ; "git backend")] | ||
| fn keep_on_rewrite(backend: TestRepoBackend) { | ||
| let settings = user_settings(true); | ||
|
|
||
| let signer = Signer::new(Some(Box::new(TestSigningBackend)), vec![]); | ||
| let test_workspace = TestWorkspace::init_with_backend_and_signer(&settings, backend, signer); | ||
|
|
||
| let repo = &test_workspace.repo; | ||
|
|
||
| let settings = settings.clone(); | ||
| let repo = repo.clone(); | ||
| let mut tx = repo.start_transaction(&settings, "test"); | ||
| let commit = create_random_commit(tx.mut_repo(), &settings) | ||
| .set_sign_behavior(SignBehavior::Own) | ||
| .write() | ||
| .unwrap(); | ||
| tx.commit(); | ||
|
|
||
| let mut tx = repo.start_transaction(&settings, "test"); | ||
| let mut_repo = tx.mut_repo(); | ||
| let rewritten = mut_repo.rewrite_commit(&settings, &commit).write().unwrap(); | ||
|
|
||
| let commit = repo.store().get_commit(rewritten.id()).unwrap(); | ||
| assert_eq!(commit.verification().unwrap(), good_verification()); | ||
| } | ||
|
|
||
| #[test_case(TestRepoBackend::Git ; "git backend")] | ||
| fn manual_drop_on_rewrite(backend: TestRepoBackend) { | ||
| let settings = user_settings(true); | ||
|
|
||
| let signer = Signer::new(Some(Box::new(TestSigningBackend)), vec![]); | ||
| let test_workspace = TestWorkspace::init_with_backend_and_signer(&settings, backend, signer); | ||
|
|
||
| let repo = &test_workspace.repo; | ||
|
|
||
| let settings = settings.clone(); | ||
| let repo = repo.clone(); | ||
| let mut tx = repo.start_transaction(&settings, "test"); | ||
| let commit = create_random_commit(tx.mut_repo(), &settings) | ||
| .set_sign_behavior(SignBehavior::Own) | ||
| .write() | ||
| .unwrap(); | ||
| tx.commit(); | ||
|
|
||
| let mut tx = repo.start_transaction(&settings, "test"); | ||
| let mut_repo = tx.mut_repo(); | ||
| let rewritten = mut_repo | ||
| .rewrite_commit(&settings, &commit) | ||
| .set_sign_behavior(SignBehavior::Drop) | ||
| .write() | ||
| .unwrap(); | ||
|
|
||
| let commit = repo.store().get_commit(rewritten.id()).unwrap(); | ||
| assert_eq!(commit.verification().unwrap(), None); | ||
| } | ||
|
|
||
| #[test_case(TestRepoBackend::Git ; "git backend")] | ||
| fn forced(backend: TestRepoBackend) { | ||
| let settings = user_settings(true); | ||
|
|
||
| let signer = Signer::new(Some(Box::new(TestSigningBackend)), vec![]); | ||
| let test_workspace = TestWorkspace::init_with_backend_and_signer(&settings, backend, signer); | ||
|
|
||
| let repo = &test_workspace.repo; | ||
|
|
||
| let settings = settings.clone(); | ||
| let repo = repo.clone(); | ||
| let mut tx = repo.start_transaction(&settings, "test"); | ||
| let commit = create_random_commit(tx.mut_repo(), &settings) | ||
| .set_sign_behavior(SignBehavior::Force) | ||
| .set_author(someone_else()) | ||
| .write() | ||
| .unwrap(); | ||
| tx.commit(); | ||
|
|
||
| let commit = repo.store().get_commit(commit.id()).unwrap(); | ||
| assert_eq!(commit.verification().unwrap(), good_verification()); | ||
| } | ||
|
|
||
| #[test_case(TestRepoBackend::Git ; "git backend")] | ||
| fn configured(backend: TestRepoBackend) { | ||
| let settings = user_settings(true); | ||
|
|
||
| let signer = Signer::new(Some(Box::new(TestSigningBackend)), vec![]); | ||
| let test_workspace = TestWorkspace::init_with_backend_and_signer(&settings, backend, signer); | ||
|
|
||
| let repo = &test_workspace.repo; | ||
|
|
||
| let settings = settings.clone(); | ||
| let repo = repo.clone(); | ||
| let mut tx = repo.start_transaction(&settings, "test"); | ||
| let commit = write_random_commit(tx.mut_repo(), &settings); | ||
| tx.commit(); | ||
|
|
||
| let commit = repo.store().get_commit(commit.id()).unwrap(); | ||
| assert_eq!(commit.verification().unwrap(), good_verification()); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.