nightly clippy fixes

cli/src/commit_templater.rs

@@ -1028,7 +1028,7 @@ impl RefName {
     fn is_tracking_present(&self) -> bool {
         self.tracking_ref
             .as_ref()
-            .map_or(false, |tracking| tracking.target.is_present())
+            .is_some_and(|tracking| tracking.target.is_present())
     }
 
     /// Number of commits ahead of the tracking local ref.

cli/src/git_util.rs

@@ -481,7 +481,7 @@ pub fn git_fetch(
             GitFetchError::InvalidBranchPattern => {
                 if branch
                     .iter()
-                    .any(|pattern| pattern.as_exact().map_or(false, |s| s.contains('*')))
+                    .any(|pattern| pattern.as_exact().is_some_and(|s| s.contains('*')))
                 {
                     user_error_with_hint(
                         err,

lib/src/default_index/revset_engine.rs

@@ -270,7 +270,7 @@ impl PositionsAccumulatorInner<'_> {
         desired_position: IndexPosition,
     ) -> Result<(), RevsetEvaluationError> {
         let last_position = self.consumed_positions.last();
-        if last_position.map_or(false, |&pos| pos <= desired_position) {
+        if last_position.is_some_and(|&pos| pos <= desired_position) {
             return Ok(());
         }
         while let Some(position) = self.walk.next(index).transpose()? {
@@ -1324,7 +1324,7 @@ fn match_lines<'a: 'b, 'b>(
     text.split_inclusive(|b| *b == b'\n').filter(|line| {
         let line = line.strip_suffix(b"\n").unwrap_or(line);
         // TODO: add .matches_bytes() or .to_bytes_matcher()
-        str::from_utf8(line).map_or(false, |line| pattern.matches(line))
+        str::from_utf8(line).is_ok_and(|line| pattern.matches(line))
     })
 }
 

lib/src/default_index/store.rs

@@ -244,7 +244,7 @@ impl DefaultIndexStore {
         let parent_file_has_id = |id: &CommitId| {
             maybe_parent_file
                 .as_ref()
-                .map_or(false, |segment| segment.as_composite().has_id(id))
+                .is_some_and(|segment| segment.as_composite().has_id(id))
         };
         let get_commit_with_op = |commit_id: &CommitId, op_id: &OperationId| {
             let op_id = op_id.clone();

lib/src/git.rs

@@ -174,7 +174,7 @@ fn resolve_git_ref_to_commit_id(
     let peeled_id = peeling_ref.into_owned().into_fully_peeled_id().ok()?;
     let is_commit = peeled_id
         .object()
-        .map_or(false, |object| object.kind.is_commit());
+        .is_ok_and(|object| object.kind.is_commit());
     is_commit.then(|| CommitId::from_bytes(peeled_id.as_bytes()))
 }
 

lib/src/matchers.rs

@@ -142,7 +142,7 @@ impl Matcher for FilesMatcher {
     fn matches(&self, file: &RepoPath) -> bool {
         self.tree
             .get(file)
-            .map_or(false, |sub| sub.value == FilesNodeKind::File)
+            .is_some_and(|sub| sub.value == FilesNodeKind::File)
     }
 
     fn visit(&self, dir: &RepoPath) -> Visit {