Skip to content

Commit

Permalink
cli: allow branch list to combine -r and -a
Browse files Browse the repository at this point in the history
  • Loading branch information
Kintaro committed Mar 31, 2024
1 parent bbe906b commit 0b5dd5b
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* `jj duplicate` and `jj abandon` can now take more than a single `-r` argument,
for consistency with other commands.

* `jj branch list` now allows combining `-r` and `-a` options.

### Fixed bugs

## [0.15.1] - 2024-03-06
Expand Down
2 changes: 1 addition & 1 deletion cli/src/commands/branch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ pub struct BranchDeleteArgs {
pub struct BranchListArgs {
/// Show all tracking and non-tracking remote branches including the ones
/// whose targets are synchronized with the local branches.
#[arg(long, short, conflicts_with_all = ["names", "revisions", "tracked"])]
#[arg(long, short, conflicts_with_all = ["names", "tracked"])]
all: bool,

/// Show remote tracked branches only. Omits local Git-tracking branches by
Expand Down
32 changes: 32 additions & 0 deletions cli/tests/test_branch_command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1388,6 +1388,38 @@ fn test_branch_list_conflicted() {
"###);
}

#[test]
fn test_branch_list_revset_all() {
let test_env = TestEnvironment::default();
test_env.add_config("git.auto-local-branch = true");

// Initialize remote refs
test_env.jj_cmd_ok(test_env.env_root(), &["init", "repo", "--git"]);
let path = test_env.env_root().join("repo");
for branch in [
"branch-a",
"branch-b",
] {
test_env.jj_cmd_ok(&path, &["new", "root()", "-m", branch]);
test_env.jj_cmd_ok(&path, &["branch", "create", branch]);
}
test_env.jj_cmd_ok(&path, &["git", "export"]);

insta::assert_snapshot!(
test_env.jj_cmd_success(&path, &["branch", "list", "--all"]), @r###"
branch-a: rlvkpnrz 05e91824 (empty) branch-a
@git: rlvkpnrz 05e91824 (empty) branch-a
branch-b: zsuskuln 6dfacaa1 (empty) branch-b
@git: zsuskuln 6dfacaa1 (empty) branch-b
"###);

insta::assert_snapshot!(
test_env.jj_cmd_success(&path, &["branch", "list", "--all", "-r", "description(branch-a)"]), @r###"
branch-a: rlvkpnrz 05e91824 (empty) branch-a
@git: rlvkpnrz 05e91824 (empty) branch-a
"###);
}

fn get_log_output(test_env: &TestEnvironment, cwd: &Path) -> String {
let template = r#"branches ++ " " ++ commit_id.short()"#;
test_env.jj_cmd_success(cwd, &["log", "-T", template])
Expand Down

0 comments on commit 0b5dd5b

Please sign in to comment.