Fixed two bugs #57
Open
Fixed two bugs #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tina-nova
commented
Sep 12, 2021
tina-nova
commented
- Line 787: Fixed a bug where Jidesha can't autofill the description text field (reference here: not showing description on google calender #55)
- Line 1253: Fixed a bug that showed the quick add button when the Reminders or Tasks tab is active (the button doesn't do anything when the Events tab is not active)
- Line 787: Fixed a bug where Jidesha can't autofill the description text field (reference here: jitsi#55) - Line 1253: Fixed a bug that showed the quick add button when the Reminders or Tasks tab is active (the button doesn't do anything when the Events tab is not active)
tina-nova
commented
Sep 12, 2021
| @@ -784,7 +784,7 @@ class G2Description extends Description { | |||
| * @returns {*} | |||
| */ | |||
| get element() { | |||
| var description = $('#xDescIn > [role="textbox"]'); | |||
| var description = $('#xDescIn > [contenteditable="true"]'); | |||
There was a problem hiding this comment.
xDescIn is not (no longer?) editable using the textbox attribute. This fixes it by going straight to the child element that is editable.
|
Is this still relevant? Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.