fixes AttributeError: 'NoneType'... when views are activated via the Goto Anything palette
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't run git_gutter in a view if it has no window: fixes AttributeError: 'NoneType'... when views are activated via the `Goto Anything` palette
|
This looks ok, in what situation does a view not have a window tho? |
|
transient views e.g. those opened with window.open_file('...', sublime.TRANSIENT) or those that get previewed as you type inside the goto anything palette have no window associated unless you edit them at which point they are assigned a tab, etc. |
|
@DisposaBoy ahh yes. I much prefer the way ST3 handles transient views. I have a major bug I can't seem to fix in my MaxPane plugin dealing with transient views in ST2 (but theres no issue in ST3.) I will pull this in when I get a chance. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't run git_gutter in a view if it has no window: fixes AttributeError: 'NoneType'... when views are activated via the
Goto Anythingpalette