[WIP] first untested attempt at adding the injector #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. I had to add the ca-certificates package to the Docker image because I was getting an X.509 error after creating the multi-stage build. You might need to add this to your PR. |
|
Does this add the secret sidecar to all pods deployed into a namespace? It should only inject the sidecar into pods that have a particular annotation, e.g. secret.amazonaws.com: <secret_name>. Need to think about how to add the right serviceAccountName to the injected pod. |
|
I figured it would but I have not gotten that far with the annotation part. |
|
Can you test and resubmit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to show I am putting effort into this.