Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OTTR_template_website.Rproj to OTTR_Template_Website.Rproj #64

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

howardbaik
Copy link
Contributor

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Renamed OTTR_template_website.Rproj to OTTR_Template_Website.Rproj.

What was your approach?

Manually changed the file name on GitHub.

What GitHub issue does your pull request address?

#63

Tell potential reviewers what kind of feedback you are soliciting.

When I clone this repo into my local system, I noticed an inconsistency:

  • The folder that was created was named OTTR_Template_Website
  • The .Rproj file is named OTTR_template_website.Rproj.
  • The name of this repo on GitHub is OTTR_Template_Website.

Why does this matter? Well, when I'm trying to make changes to this repo, I use Alfred to open up this repo on my Mac, and seeing this difference in names bothered me every time. I learned to use Alfred as part of my project workflow after watching this 2-min video by Hadley Wickham: https://youtu.be/boKFxBniUH0?si=oIEejAtx9TgCVEww

@howardbaik howardbaik requested review from cansavvy and kweav March 22, 2024 19:22
@howardbaik howardbaik linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Mar 22, 2024

No broken url errors! 🎉
Comment updated at 2024-03-22-19:23:45 with changes from d5552c0

Copy link

github-actions bot commented Mar 22, 2024

No spelling errors! 🎉
Comment updated at 2024-03-22-19:23:46 with changes from d5552c0

Copy link

👀 Quick preview of website here *
🔬 Comprehensive download of the website here

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-03-22 with changes from the latest commit d5552c0

Copy link
Contributor

@kweav kweav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that no other file or GitHub Action calls the Rproj file, so this should be good to go

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @howardbaek

@cansavvy cansavvy merged commit 2ef516c into main Mar 25, 2024
6 checks passed
@cansavvy cansavvy deleted the 63-consistency-between-repo-name-and-rproj-file branch March 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistency between repo name and rproj file
3 participants