Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE-0: added -user parameter to Send-GraphMailMessage #13

Open
wants to merge 1 commit into
base: PlusPlus
Choose a base branch
from

Conversation

fasteiner
Copy link

added -user parameter to Send-GraphMailMessage, updated documentation, added parameterhelp, tested with a few users, including me (which requires delegated permissions instead of app permissions)

…cumentation, added parameterhelp, tested with a few users, including me (which requires delegated permissions instead of app permissions)
@fasteiner
Copy link
Author

@jhoneill what do you think about my changes? What can I improve so you will merge it into your repository?

KR Fabian

@fasteiner
Copy link
Author

@jhoneill please reply

@jhoneill
Copy link
Owner

jhoneill commented Aug 2, 2023

@fasteiner Sorry this project has been frozen for a few months because of other things happening and trying to do it alone.

It causes issues for maintainers if someone wants to reformat the code, move the help around etc. because in a sea of changes there are are handful of lines which have changed, and one function in among many now conforms to a different set of conventions layout conventions. Even if some of practices look "wrong", if they aren't affecting the result "fixing" them with another change just complicates things.

But: your idea is a good one and I'll look to merge it in. I'm now working on the project again - a client needs the functionality and would benefit from a few additions - so this should happen soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants