[FIX] replaces hashValues method call with Object.hash method call

[REMOVED] removed invalid lint `invalid_dependency`
jhomlala · Dec 17, 2024 · f91f9f1 · f91f9f1
1 parent 40e88b9
commit f91f9f1
Show file tree

Hide file tree

Showing 13 changed files with 86 additions and 108 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -15,7 +15,6 @@ linter:
     prefer_constructors_over_static_methods: false
     sort_unnamed_constructors_first: false
     sized_box_for_whitespace: false
-    invalid_dependency: false
     sort_pub_dependencies: false
     avoid_unnecessary_containers: false
     use_setters_to_change_properties: false

diff --git a/lib/src/asms/better_player_asms_track.dart b/lib/src/asms/better_player_asms_track.dart
@@ -40,7 +40,7 @@ class BetterPlayerAsmsTrack {
   int get hashCode => super.hashCode;
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     return other is BetterPlayerAsmsTrack &&
         width == other.width &&
         height == other.height &&

diff --git a/lib/src/core/better_player_controller.dart b/lib/src/core/better_player_controller.dart
@@ -522,9 +522,9 @@ class BetterPlayerController {
         }
         break;
 
-      default:
+      /*default:
         throw UnimplementedError(
-            "${betterPlayerDataSource.type} is not implemented");
+            "${betterPlayerDataSource.type} is not implemented");*/
     }
     await _initializeVideo();
   }
@@ -1260,7 +1260,7 @@ class BetterPlayerController {
   ///cache started for given [betterPlayerDataSource] then it will be ignored.
   Future<void> stopPreCache(
       BetterPlayerDataSource betterPlayerDataSource) async {
-    return VideoPlayerController?.stopPreCache(betterPlayerDataSource.url,
+    return VideoPlayerController.stopPreCache(betterPlayerDataSource.url,
         betterPlayerDataSource.cacheConfiguration?.key);
   }
 

diff --git a/lib/src/dash/better_player_dash_utils.dart b/lib/src/dash/better_player_dash_utils.dart
@@ -85,8 +85,7 @@ class BetterPlayerDashUtils {
     String? name = node.getAttribute('label');
     final String? language = node.getAttribute('lang');
     final String? mimeType = node.getAttribute('mimeType');
-    String? url =
-        node.getElement('Representation')?.getElement('BaseURL')?.text;
+    String? url = node.getElement('Representation')?.getElement('BaseURL')?.value;
     if (url?.contains("http") == false) {
       final Uri masterPlaylistUri = Uri.parse(masterPlaylistUrl);
       final pathSegments = <String>[...masterPlaylistUri.pathSegments];

diff --git a/lib/src/hls/hls_parser/drm_init_data.dart b/lib/src/hls/hls_parser/drm_init_data.dart
@@ -1,5 +1,4 @@
 import 'package:collection/collection.dart';
-import 'package:flutter/cupertino.dart';
 
 import 'scheme_data.dart';
 
@@ -10,7 +9,7 @@ class DrmInitData {
   final String? schemeType;
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (other is DrmInitData) {
       return schemeType == other.schemeType &&
           const ListEquality<SchemeData>().equals(other.schemeData, schemeData);
@@ -19,5 +18,5 @@ class DrmInitData {
   }
 
   @override
-  int get hashCode => hashValues(schemeType, schemeData);
+  int get hashCode => Object.hash(schemeType, schemeData);
 }
diff --git a/lib/src/hls/hls_parser/hls_track_metadata_entry.dart b/lib/src/hls/hls_parser/hls_track_metadata_entry.dart
@@ -1,6 +1,5 @@
 import 'package:better_player/src/hls/hls_parser/variant_info.dart';
 import 'package:collection/collection.dart';
-import 'package:flutter/rendering.dart';
 
 class HlsTrackMetadataEntry {
   HlsTrackMetadataEntry({this.groupId, this.name, this.variantInfos});
@@ -17,7 +16,7 @@ class HlsTrackMetadataEntry {
   final List<VariantInfo>? variantInfos;
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (other is HlsTrackMetadataEntry) {
       return other.groupId == groupId &&
           other.name == name &&
@@ -28,5 +27,5 @@ class HlsTrackMetadataEntry {
   }
 
   @override
-  int get hashCode => hashValues(groupId, name, variantInfos);
+  int get hashCode => Object.hash(groupId, name, variantInfos);
 }
diff --git a/lib/src/hls/hls_parser/metadata.dart b/lib/src/hls/hls_parser/metadata.dart
@@ -7,7 +7,7 @@ class Metadata {
   final List<HlsTrackMetadataEntry> list;
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (other is Metadata) {
       return const ListEquality<HlsTrackMetadataEntry>()
           .equals(other.list, list);

diff --git a/lib/src/hls/hls_parser/scheme_data.dart b/lib/src/hls/hls_parser/scheme_data.dart
@@ -1,7 +1,5 @@
 import 'dart:typed_data';
 
-import 'package:flutter/material.dart';
-
 class SchemeData {
   SchemeData({
 //    @required this.uuid,
@@ -36,7 +34,7 @@ class SchemeData {
       );
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (other is SchemeData) {
       return other.mimeType == mimeType &&
           other.licenseServerUrl == licenseServerUrl &&
@@ -49,7 +47,7 @@ class SchemeData {
   }
 
   @override
-  int get hashCode => hashValues(
+  int get hashCode => Object.hash(
       /*uuid, */
       licenseServerUrl,
       mimeType,

diff --git a/lib/src/hls/hls_parser/variant_info.dart b/lib/src/hls/hls_parser/variant_info.dart
@@ -1,4 +1,4 @@
-import 'package:flutter/material.dart';
+
 
 class VariantInfo {
   VariantInfo({
@@ -29,9 +29,10 @@ class VariantInfo {
   final String? captionGroupId;
 
   @override
-  bool operator ==(dynamic other) {
+  bool operator ==(Object other) {
     if (other is VariantInfo) {
-      return other.bitrate == bitrate &&
+      return other.runtimeType == runtimeType &&
+          other.bitrate == bitrate &&
           other.videoGroupId == videoGroupId &&
           other.audioGroupId == audioGroupId &&
           other.subtitleGroupId == subtitleGroupId &&
@@ -41,6 +42,5 @@ class VariantInfo {
   }
 
   @override
-  int get hashCode => hashValues(
-      bitrate, videoGroupId, audioGroupId, subtitleGroupId, captionGroupId);
+  int get hashCode => Object.hash(bitrate, videoGroupId, audioGroupId, subtitleGroupId, captionGroupId);
 }