Add the ability to set deamon command line options #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamawithonel
force-pushed
the
smartd_opts
branch
4 times, most recently
from
46f168e to
10c55ef
Compare
Merged
|
@lamawithonel Sorry for the slow maintenance activity. Could you rebase on current master? |
|
Do you want any of the spec_cleanup changes? |
|
I'm looking at using this module but it seems like it hasn't been maintained for some time. @lamawithonel is this still an issue? |
This adds the parameter `smartd_opts` to set the command line options for `smartd(8)` using an Augeas resource, and the boolean parameter `manage_smartd_opts` to toggle this behavior. By default `smartd_opts` contains options that will save disk state and attributes to `/var/lib/smartmontool`, except where SELinux restricts this behavior. To maintain backwards compatability, however, `manage_smartd_opts` is set to `false` by default. New parameters: * `smartd_opts` * `manage_smartd_opts` New resources: * Augeas['smartd_opts'] * File['/var/lib/smartmontools']
|
I've rebased the manifest changes onto the current |
|
Thanks for doing that!
…--
Sam McLeod
On 5 Jun 2018, at 07:48, Lucas Yamanishi ***@***.***> wrote:
I've rebased the manifest changes onto the current master branch, but the spec tests were a conflict nightmare and pretty much need to be rewritten. I had to force-push due to the conflicts, but the original spec tests are available at 4298dd1 if anyone wants to tackle that. It's not a priority for me right now.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the parameter
smartd_optsto set the command line options forsmartd(8)using an Augeas resource and the boolean parametermanage_smartd_optsto toggle the behavior. By defaultsmartd_optscontains options that will save disk state and attributes to/var/lib/smartmontool, except where SELinux restricts write access. To maintain backwards compatibility, however,manage_smartd_optsis set tofalseby default.This is based off PR #51, so it includes all those other commits. The only difference is 4298dd1. Other than the tests, It could probably be rebased, if needed.
New parameters:
smartd_optsmanage_smartd_optsNew resources: