Improve Test Coverage - JdlService

[roexber]

Related to #213

[SudharakaP]

I would use the property application.github.host from application.yml instead of hardcoding https://www.github.com

[roexber]

Done

[SudharakaP]

@roexber : Not sure this is done, as I don't see the property application.github.host being used. Also we need to add that property to the application.yml file as it's not there;

jhipster-online/src/test/resources/config/application.yml

Line 117 in 8fe29ce

# application:

. So ultimately we would have,

application:
    github:
        host: https://github.com
    gitlab:
        host: https://gitlab.com

in the application.yml file and then you could refer to that using .willReturn(applicationProperties.getGithub().getHost()).

[roexber]

@SudharakaP due to

@EnableConfigurationProperties(value = ApplicationProperties.class)
@TestPropertySource("classpath:config/application.yml")

on the test class and
@Autowired
private ApplicationProperties applicationProperties;

the properties are loaded from
src/test/resources/config/application.yml

I'm not explicitly overriding since there are sensible defaults set on io.github.jhipster.online.config.ApplicationProperties Github and Gitlab child classes

public static class Github {

    private String host = "https://github.com";

Testing if spring property loading works seemed out of scope, I'll override them anyway to make sure the default is substituted.

[roexber]

Tried adding

application:
github:
host: github.test
gitlab:
host: gitlab.test

to the src/test/resources/config/application.yml without much luck... not sure how to go about it next

[roexber]

Managed to figure this one out using the help of @patrickhancke

[roexber]

@SudharakaP should be better now as its picking up the src/test/resrouces application.yml configuration in the test assertions

[SudharakaP]

@SudharakaP should be better now as its picking up the src/test/resrouces application.yml configuration in the test assertions

Thanks a lot for the work. I've added some minor comments to the review, and after that I think we are good to go. 👍🏽

[SudharakaP]

@roexber : Thanks a lot for your contribution, greatly appreciate what you are doing here. 😄