Improve-test-coverage - AuditEventConverter, JdlMetadataService, YoRC…

[Strat1987]

Related to #213

[CLAassistant]

All committers have signed the CLA.

[SudharakaP]

@Strat1987 : Hi, thanks for submitting the PR. 😄

1. Could you please sign the CLA.

2. There seems to be a CI failure in the newly added file AuditEventConverterTest.java at line 59. I think there's a problem with the syntax.

-> at io.github.jhipster.online.config.audit.AuditEventConverterTest.convertToAuditEventNullEvent(AuditEventConverterTest.java:59)

You cannot use argument matchers outside of verification or stubbing.
Examples of correct usage of argument matchers:
    when(mock.get(anyInt())).thenReturn(null);
    doThrow(new RuntimeException()).when(mock).someVoidMethod(anyObject());
    verify(mock).someMethod(contains("foo"))

[Strat1987]

1. the version wouldn't load last time for the CLA, was successful this time around.
2. Using IntelliJ test runner, this assertion does succeed, I do feel the implementation is strange since it adds null objects to the list. not empty check suffices as I'm only adding the null value, no need to explicitly assert it

[SudharakaP]

@Strat1987 : The CLA doesn't seem to be signed yet. Did you already signed it? Maybe there's something wrong on our side? 🤔

cc: @pascalgrimaud

[pascalgrimaud]

I think it's because the commits come from @roexber account, and you tried to sign the cla with @Strat1987 account

[SudharakaP]

I think it's because the commits come from @roexber account, and you tried to sign the cla with @Strat1987 account

@pascalgrimaud : Thanks. Nice catch. 👍🏼

[roexber]

I've now accepted CLA using the github account I also used for the commits, apologies

[pascalgrimaud]

No worry @roexber : don't be sorry for helping Open Source projects :-)

[SudharakaP]

I've now accepted CLA using the github account I also used for the commits, apologies

@Strat1987 : No worries, thanks a bunch. Can you re-base and run prettier; npm run prettier:format so that we have the formatting consistent. 😄

EDIT: You don't have to run prettier as it's auto run on commit anyways. My mistake. 😢

[roexber]

@SudharakaP Done, It's a challenge for me performing this many history changing GIT commands which I'm really not accustomed with in my day to day.

[SudharakaP]

@roexber : Thanks much for your contribution. Looks awesome. 👍🏼

[roexber]

@SudharakaP thanks for the kind words. I'm happy to contribute since JHipster greatly helped in coming back to the spring eco system

[SudharakaP]

You are welcome. 🙃

…

On Sun, Oct 18, 2020, 11:46 PM roexber ***@***.***> wrote: @SudharakaP <https://github.com/SudharakaP> thanks for the kind words. I'm happy to contribute since JHipster greatly helped in coming back to the spring eco system — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#247 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC64D7PZKZBD5ZTGWPCFT4LSLPOFXANCNFSM4SLW7CCQ> .