Add latest tag and make image name variable #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgosmann
requested changes
Oct 3, 2023
There was a problem hiding this comment.
Thank you for the PR. It is possible to invoke the docker-publish workflow for any version published to PyPI. Thus, I think the latest tag should only be assigned if the workflow has been invoked for the latest version.
The following approach could be taken to determine whether a specific version is the latest version:
- Do a
GETrequest againsthttps://pypi.org/simple/dmarc-metrics-exporterwith anAccept: application/vnd.pypi.simple.v1+jsonheader. (Cp. PEP 691) - Extract the
versionskey from the JSON. (Cp. PEP 700) - Determine the latest version from the extracted list. As we only need to handle version formats used in this project, the version numbers can be assumed to be semantic versioning for the most part. There is the version
0.5.1.dev0which is a prerelease, but does not follow the semantic versioning convention to mark pre-releases (it should be0.5.1-dev0. - Only tag the the Docker image with
latestif it has been built for the latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added a latest tag for atomatic updates and changed the static dockerhub name to a variable