Miscellaneous refactors #10457
Merged
Miscellaneous refactors #10457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more efficient than the existing one.
"all f []" is always true, so "null xs || all f xs" can be simplified to just "all f xs".
josephcsible
force-pushed
the
refactors
branch
from
f6a4a3a to
773bc54
Compare
jgm
requested changes
Dec 14, 2024
src/Text/Pandoc/Writers/ANSI.hs
Outdated
| @@ -82,7 +82,7 @@ pandocToANSI opts (Pandoc meta blocks) = do | |||
| body <- blockListToANSI opts blocks' | |||
| notes <- gets $ reverse . stNotes | |||
| let notemark x = D.literal (tshow (x :: Int) <> ".") <+> D.space | |||
| let marks = take (length notes) $ map notemark [1..] | |||
| let marks = map notemark [1..length notes + 1] | |||
There was a problem hiding this comment.
Is the + 1 here right? I don't see why. Previously marks was a list of the same length as notes. With this change it will be 1 longer than notes.
There was a problem hiding this comment.
Whoops, you're right. Fixed.
src/Text/Pandoc/Readers/HTML.hs
Outdated
| let isDisplay = case lookup "display" attr of | ||
| Just "block" -> True | ||
| _ -> False | ||
| let possiblyDisplayMath = case lookup "display" attr of |
There was a problem hiding this comment.
Instead of possiblyDisplayMath, I think constructor would be better.
Instead of storing isDisplay and then always choosing displayMath or math based on that, just store displayMath or math directly.
josephcsible
force-pushed
the
refactors
branch
from
773bc54 to
78e359d
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.