-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue10294 new code for two column layout on typst 0.12.x #10324
Conversation
layout instructions for two column layout has changed. see typst/typst#5215
two column layout instructions have changed in typst 0.12; see typst/typst#5215 for details.
fixed braces (I hope...)
fix indent
fixed indentation?
Update default.typst for upcoming typst 0.12
template.typst has a |
Because To tell the truth, I am still not quite sure why so many defaults are set in So, if i were to suggest something, i'd say that the layout code should be moved from |
Not so. You can put variables in partials! |
you're right; and doing so keeps the change less intrusive than the other one. proceeding. |
set columns in template.typst
revert original `cols` variable from `template.typst`; `template.typst` keeps the original `page` settings
fixed regression (removed `paper` from `page` accidentally)...
misplaced `cols` variable...
restored empty line...
prettified (sort of) blank space...
I think it is ready now... |
reverted cosmetic changes for functional ones... effectively restoring original version, iiuc.
removed extra space, added while debugging for clarity
space test added, for legibility
restored blank line, as in the original, to minimize the diff file
restored insets
removed extra blank
cleanup
cleanup
looks good - I'll merge this and update the tests. |
Typst 0.12.0 introduces some changes for two column layout, preferring
#page(columns: <N>)
for global two column output, and supplementing#place
with new parametersscope
andclearance
to layout one column content (such as titleplage) on two column documents. This patch tries to upgrade thetypst.template
to comply with the newer requirements. Check issue 10294.