Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly created database is now identified by flag #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rasmusson
Copy link

Newly created database is now identified by flag instead of looking if the version number is 0

Newly created database is now identified by flag instead of looking if the version number is 0
@rasmusson
Copy link
Author

What do you think, can this be merged soon?

@jon-adams
Copy link

What is the purpose of this patch? In other words, why does using this flag instead of checking !=0 make things better? Are there any bugs with the version check as is? Or what scenarios will be better with this change?

@rasmusson
Copy link
Author

I had an issue where the database version I was upgrading from was 0. With
the old version no upgrade would be done

Stefan

On 16 May 2014 18:07, Jon Adams [email protected] wrote:

What is the purpose of this patch? In other words, why does using this
flag instead of checking !=0 make things better? Are there any bugs with
the version check as is? Or what scenarios will be better with this change?


Reply to this email directly or view it on GitHubhttps://github.com//pull/30#issuecomment-43349230
.

@biegleux
Copy link

this is not an issue of the library
database version number should start from 1, according to docs

@rasmusson
Copy link
Author

No but it can be a problem if you have an earlier DB with version 0, as in
my case

Stefan

On 28 April 2015 at 14:40, Tibor [email protected] wrote:

this is not an issue of the library
database version number should start from 1, according to docs


Reply to this email directly or view it on GitHub
#30 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants