Custom and dynamic row classes and optionally remove odd/even classes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm aware that you shouldn't mess with the rake file, but since builds were failing for this reason, I took this liberty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration: another way of specifying classes for rows, see issues #21 and #24. In my solution we do this by calling
row_classin the block passed totable_for.You can use a string or pass a block to create dynamic classes.
Syntax may be a bit suboptimal, since you shouldn't output the result of the method call.
I also added an option to omit the odd/even classes by passing an option to
row_class, as per issue #28