Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output analytics for GH integration #270

Merged
merged 9 commits into from
Dec 25, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Dec 23, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Adding 2 new format changes, when running on Github CI:

  1. In the Sarif Format, at the help section. we are adding a hidden prefix (pixel) for analytics.
  2. In the Job Summary, we are adding query params to the generated links

@attiasas attiasas added the ignore for release Automatically generated release notes label Dec 23, 2024
@attiasas attiasas marked this pull request as draft December 23, 2024 14:03
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@attiasas attiasas marked this pull request as ready for review December 24, 2024 12:12
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 24, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 25, 2024
@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request and removed ignore for release Automatically generated release notes labels Dec 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 25, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 25, 2024
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/scan 0.00% (ø)
github.com/jfrog/jfrog-cli-security/jas 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/formats/sarifutils 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion/simplejsonparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/output 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/scan/buildscan.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/scan/scan.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/formats/sarifutils/sarifutils.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/formats/sarifutils/test_sarifutils.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/conversion/convertor.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser/sarifparser.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/output/resultwriter.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/output/securityJobSummary.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/utils.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/jas/common_test.go
  • github.com/jfrog/jfrog-cli-security/utils/formats/sarifutils/sarifutils_test.go
  • github.com/jfrog/jfrog-cli-security/utils/results/common_test.go
  • github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser/sarifparser_test.go
  • github.com/jfrog/jfrog-cli-security/utils/results/conversion/simplejsonparser/simplejsonparser_test.go
  • github.com/jfrog/jfrog-cli-security/utils/results/output/securityJobSummary_test.go

Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit 74520fe into jfrog:dev Dec 25, 2024
53 checks passed
@attiasas attiasas deleted the add_gh_jas_analytics branch December 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants