Fix version maven source plugin #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix_version_maven_source_plugin
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the version of the
maven-source-pluginto3.2.1.The decision to pin the version is due to issues introduced in versions
3.3+, where the plugin generates source files at the parent level. This behavior causes build conflicts that could not be resolved with the current configuration.As part of troubleshooting, I attempted switching the goal from
jartojar-no-forkbased on recommendations (e.g., StackOverflow post, but this did not resolve the issue in our build setup.If you are reviewing this in the future, you may try updating the plugin version to see if the conflicts have been addressed in newer releases and if the build passes successfully.