Add terraform examples for aws #1958
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldada
reviewed
Jan 28, 2025
examples/terraform-examples/LICENSE
Outdated
eldada
reviewed
Jan 28, 2025
| } | ||
|
|
||
| # Output the command to install Artifactory with Helm | ||
| # TODO: Fix Xray sizing breaking the template |
There was a problem hiding this comment.
We need to see if the Xray sizing issue is fixed and update this
There was a problem hiding this comment.
I will check that
eldada
reviewed
Jan 28, 2025
| } | ||
|
|
||
| variable "jfrog_platform_chart_version" { | ||
| default = "10.20.3" |
There was a problem hiding this comment.
will update once it's released.
eldada
reviewed
Jan 28, 2025
| module "vpc" { | ||
| source = "terraform-aws-modules/vpc/aws" | ||
|
|
||
| name = "jfrog-vpc" |
There was a problem hiding this comment.
We need to start using the random_pet resource and append it to all resources created to create uniqueness.
name = "jfrog-vpc-${random_pet.unique.id}"
eldada
reviewed
Jan 28, 2025
| # Setup the required variables | ||
|
|
||
| variable "region" { | ||
| default = "eu-central-1" |
eldada
reviewed
Jan 28, 2025
eldada
reviewed
Jan 28, 2025
There was a problem hiding this comment.
When updating to jfrog-platform 11.x, update this file by removing unsupported apps.
shahiinn
force-pushed
the
terraform-examples-1
branch
from
0e3f816 to
509c90c
Compare
shahiinn
force-pushed
the
terraform-examples-1
branch
from
509c90c to
2cc41ec
Compare
chukka
reviewed
Jan 29, 2025
| @@ -0,0 +1,14 @@ | |||
| # Terraform Playground | |||
| This repository contains a collection of Terraform configurations that I use to learn and experiment with Terraform. | |||
shahiinn
force-pushed
the
terraform-examples-1
branch
2 times, most recently
from
71ca44d to
b654cab
Compare
shahiinn
force-pushed
the
terraform-examples-1
branch
from
b654cab to
5159a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add terraform examples for aws
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory])What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: