Add named constructor parsing #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfecher
approved these changes
Sep 2, 2023
There was a problem hiding this comment.
Looks like a good start! I'd eventually like to be able to parse more expressions then just function arguments in the rhs of the = of each field, but I can see how this would be difficult with the expression parser trying to parse commas as tuples normally.
Thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the parsing part of #163.
I recommend looking only at the second commit, the first is just noise. Feel free to cherry-pick only the second one. I included it because
rustfmtis automatically applied for me.I tried to cover all the edge cases in
examples/parsing/named_constructor.anbut if I missed or misunderstood something feel free to point it out.