Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted to portable app; removed site-specific components #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

badrihippo
Copy link

Rearranged directory structure and made urls and templates more generic, to make the app portable.
Also removed settings.py, and non-app-specific urls in urls.py.

This is a major change; I don't know if it's what the app was originally meant for, but I was doing it anyway for my project and thought it may be useful to others. If it doesn't fit then maybe it could be made into a separate project...?

Note: I also removed the four required survey fields (interviewer, interviewee, conditions, comments) because they didn't work for me: sorry, I know I should have done that in a separate commit, but I'm new to git so still haven't fully got the hang of it :(

…ake the app portable.

Also removed settings.py, and non-app-specific urls in urls.py
@Pierre-Sassoulas
Copy link

Pierre-Sassoulas commented Mar 14, 2017

I've tried to cherry pick this in my fork, but as you removed the manage.py and base.html, it can't work as a standalone anymore.

@badrihippo
Copy link
Author

Wow. This was a long time ago.

But if I remember rightly, I was trying to make it into an embedded app instead of a standalone one. On second thoughts, you probably shouldn't be merging it here in that case?

@Pierre-Sassoulas
Copy link

Pierre-Sassoulas commented Mar 14, 2017

That's right. I want to use it as a portable app too, but I also still wanted to test in standalone before integrating (in order to see how easy it is to create a survey, add question etc.). I think adding those files permit to do both : Pierre-Sassoulas@82bcb7a

@badrihippo
Copy link
Author

Then I guess we should keep the portable package, and have a dummy app as well for testing. So when someone wants to deploy it, they can copy just the portable part (preferably in a separate folder) and leave the rest.

Is it possible to merge it in but add base.html and manage.py back? If not, I'll look at it properly this weekend and see if I can sort it out.

@Pierre-Sassoulas
Copy link

Pierre-Sassoulas commented Mar 14, 2017

I think its what I've done in Pierre-Sassoulas@82bcb7a. (apply your pull request, then add base.html, manage.py and settings.py back outside of the survey directory). I did not understand what you meant by "having a dummy app for testing" so maybe not. Feel free to tell me what you meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants