test: adjusted to make it more meaningful and to pass

jessesimpson36 · Dec 31, 2024 · 7ec0b14 · 7ec0b14
1 parent e71de8c
commit 7ec0b14
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/pkg/engine/engine.go b/pkg/engine/engine.go
@@ -380,7 +380,6 @@ func determineIfFormattedErrorIsAcceptable(formattedErr error, originalErr error
 	}
 
 	equivalenceRating := (float64(matchCount) / float64(len(formattedErrTokens))) * 100
-	fmt.Printf("Rating: %f\n", equivalenceRating)
 	if equivalenceRating >= 80 {
 		return formattedErr
 	}

diff --git a/pkg/engine/engine_test.go b/pkg/engine/engine_test.go
@@ -1318,6 +1318,17 @@ func TestNestedHelpersProducesMultilineStacktrace(t *testing.T) {
 		},
 	}
 
+	expectedErrorMessage := `NestedHelperFunctions/templates/svc.yaml:1:9
+  executing "NestedHelperFunctions/templates/svc.yaml" at <include "nested_helper.name" .>: 
+    error calling include:
+NestedHelperFunctions/templates/_helpers_1.tpl:1:39
+  executing "nested_helper.name" at <include "common.names.get_name" .>: 
+    error calling include:
+NestedHelperFunctions/charts/common/templates/_helpers_2.tpl:1:50
+  executing "common.names.get_name" at <.Release.Name>: 
+    nil pointer evaluating interface {}.Name
+`
+
 	v := chartutil.Values{}
 
 	val, _ := chartutil.CoalesceValues(c, v)
@@ -1327,7 +1338,5 @@ func TestNestedHelpersProducesMultilineStacktrace(t *testing.T) {
 	_, err := Render(c, vals)
 
 	assert.NotNil(t, err)
-	if err != nil {
-		t.Errorf("Failed to render templates: %s", err)
-	}
+	assert.Equal(t, expectedErrorMessage, err.Error())
 }