-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete rewrite with new images and adapted display #10
Open
ofrohn
wants to merge
31
commits into
jeromeetienne:master
Choose a base branch
from
ofrohn:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
many new images, transparent pngs for rings & clouds
Friendly names Error handling is gud Complete documentation better solar corona
light settings
shininess adapted
refactored
InCogNiTo124
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making exactly what I needed for a project of my own d3-orrery
However, as a dedicated space geek I want my planets to look as accurate as possible, so I changed most of the images and rewrote the code massively. I left stubs for the old functions for backward compatibility though.
Rings are changed completely. Also rings for Jupiter & Neptune added
Dropped bump maps for planets with smooth surface/atmosphere (sun, gas giants, venus)
Planets are tilted in their natural manner
Image sources described in the readme