bring dev branch up to date with master branch #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read-keys-from-stdin 21 support process substitution to read keys from stdin
Cmake rewrite
The cpp version is already handled in `target_compile_features`. No need to specify it again as compiler option in `target_compile_options`. When using `target_compile_options` and including PTHash in a project that needs c++20, this otherwise breaks c++20 support for the parent project.
Do not specify c++ version again
7aecc46 changed the class name, but did not update this commented-out code.
Not setting the seed in build_from_hashes prevents users of the library from using it, as they otherwise cannot set the seed
This mirrors single_phf::position and allows users to run the hasher themselves
Set m_seed in build_from_hashes instead of build_from_keys
Fix partitioned_phf name in example.cpp
Add getters for m_seed in partitioned_phf and single_phf
Add method partitioned_phf::position
Add method internal_memory_builder_partitioned_phf::build_from_hashes
Check config.minimal_output matches PHF template parameter
Apply clang-format to util.hpp
Use universal visitors for const-ref saving
use external/bits
update external/bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.