fix warnings related to uninitialized values

jermp · May 23, 2024 · a86393e · a86393e
1 parent a1573c5
commit a86393e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/include/builders/external_memory_builder_partitioned_phf.hpp b/include/builders/external_memory_builder_partitioned_phf.hpp
@@ -134,14 +134,14 @@ struct external_memory_builder_partitioned_phf {
                     std::cout << "writing builders to disk..." << std::endl;
                 }
                 start = clock_type::now();
-                uint64_t id = i - partition_config.num_partitions;
-                for (auto& builder : in_memory_builders) {
-                    m_builders.save(builder, id);
-                    internal_memory_builder_single_phf<hasher_type>().swap(builder);
+                assert(partition_config.num_partitions == in_memory_builders.size());
+                uint64_t id = 0;
+                while (in_memory_builders.size()) {
                     ++id;
+                    m_builders.save(in_memory_builders.back(), i - id);
+                    in_memory_builders.pop_back();
                 }
                 timings.partitioning_seconds += seconds(clock_type::now() - start);
-                assert(id == i);
             };
 
             for (; i != num_partitions; ++i) {
@@ -321,4 +321,4 @@ struct external_memory_builder_partitioned_phf {
     };
 };
 
-}  // namespace pthash
+}  // namespace pthash