Add address shift #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was working with the I2C portion of your library with QEmu and found something I wanted to make you aware of.
I believe the address passed to the
i2c_startroutine should be shifted by one bit to the left. Since I2C addresses are the upper 7 bits of a byte, the 0th bit being a R/W, most I2C libraries will shift the address passed to the routine like this for the user, so the value passed in correctly shows up in the upper 7 bits of the byte that is sent.Hope that makes sense, let me know if you have any questions.
Sam