-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Lumen 5.x support #54
base: master
Are you sure you want to change the base?
Conversation
StyleCI analysis has been fixed, it shows as failed because I have used a soft reset to squash the commits. @jenssegers |
Wouldn't it be better to refactor the original service provider so that the Lumen service provider can extend it and only override Lumen specific stuff? This way there is less code duplication. |
@jenssegers That's actually a good idea, I'll work on that instead. |
Any update on this PR or your code changes @GiampaoloFalqui? |
since it's been a while,i created my PR #60 for this as @jenssegers asked. |
Thanks for the update @nickfan - I do notice that all the checks failed on that PR in StyleCI and Travis CI - @jenssegers might not be able to merge that in. |
I guess we'll have to wait for @jenssegers to look over it and hopefully merge that into master. |
Any updates on this? It'd be really nice to have Lumen support as there aren't any other packages that do this ATM. |
I am very sorry about the huge await, I have improved the Pull Request by using Inheritance. @jenssegers feel free to give a look. |
Looks like we're unable to merge due to unresolved conflicts, can you look at those? |
@bkuhl Done! |
Any news? |
The build is still failing |
Has anyone taken a look at this in awhile? |
Build fixed and code updated with the latest master changes! |
Lumen support is desperately needed. Looking at the committed files I don't see a completed test case for |
There isn't a way to test the LumenServiceProvider, it only exists for Laravel unfortunately. |
@jenssegers Is there any chance this PR is merged even if |
FWIW this morning I followed this tutorial to create a custom service provider in order to use this package with a Lumen 5.2 project, and it worked like a charm: https://recursionrecursion.co.uk/post/integrating-rollbar-with-lumen |
Hi all, any news for this? I know we can do the custom service provider, but it is best to have it on the package. |
@wjgilmore I tried that tutorial for Lumen 5.7 and it uses deprecated methods and of course fails. If James Elliot would update it for Lumen 5.7 it could make lives easier but for now, it doesn't work for the current version of Lumen |
Adds Lumen 5.x support by using Monolog\RollbarHandler.