Skip to content

Commit

Permalink
Merge pull request #135 from nesk/user-agent-type-mismatch
Browse files Browse the repository at this point in the history
Fix type mismatch on $userAgent parameters
  • Loading branch information
jenssegers authored Jan 4, 2019
2 parents 25dc2a9 + a791d58 commit 59f35c4
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/Agent.php
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ public function languages($acceptLanguage = null)
* Match a detection rule and return the matched key.
*
* @param array $rules
* @param null $userAgent
* @param string|null $userAgent
* @return string
*/
protected function findDetectionRulesAgainstUA(array $rules, $userAgent = null)
Expand All @@ -193,7 +193,7 @@ protected function findDetectionRulesAgainstUA(array $rules, $userAgent = null)
/**
* Get the browser name.
*
* @param null $userAgent
* @param string|null $userAgent
* @return string
*/
public function browser($userAgent = null)
Expand All @@ -212,7 +212,7 @@ public function browser($userAgent = null)
/**
* Get the platform name.
*
* @param string $userAgent
* @param string|null $userAgent
* @return string
*/
public function platform($userAgent = null)
Expand All @@ -229,7 +229,7 @@ public function platform($userAgent = null)
/**
* Get the device name.
*
* @param string $userAgent
* @param string|null $userAgent
* @return string
*/
public function device($userAgent = null)
Expand All @@ -248,7 +248,7 @@ public function device($userAgent = null)
/**
* Check if the device is a desktop computer.
*
* @param string $userAgent deprecated
* @param string|null $userAgent deprecated
* @param array $httpHeaders deprecated
* @return bool
*/
Expand All @@ -260,7 +260,7 @@ public function isDesktop($userAgent = null, $httpHeaders = null)
/**
* Check if the device is a mobile phone.
*
* @param string $userAgent deprecated
* @param string|null $userAgent deprecated
* @param array $httpHeaders deprecated
* @return bool
*/
Expand All @@ -272,7 +272,7 @@ public function isPhone($userAgent = null, $httpHeaders = null)
/**
* Get the robot name.
*
* @param string $userAgent
* @param string|null $userAgent
* @return string|bool
*/
public function robot($userAgent = null)
Expand All @@ -287,7 +287,7 @@ public function robot($userAgent = null)
/**
* Check if device is a robot.
*
* @param string $userAgent
* @param string|null $userAgent
* @return bool
*/
public function isRobot($userAgent = null)
Expand Down

0 comments on commit 59f35c4

Please sign in to comment.