Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Commit

Permalink
Update cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jennybc committed Jun 29, 2018
1 parent f9f12f8 commit b7ec744
Showing 1 changed file with 8 additions and 24 deletions.
32 changes: 8 additions & 24 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,29 +1,13 @@
## Test environments

* local OS X install, R 3.3.2
* Ubuntu precise (12.04.5 LTS) on travis-ci, R 3.4.0
* win-builder, release 3.4.0 and devel
* r-hub, various combinations of OS and R

This is an update to accomodate purrr 0.2.2.1, which is soon to be released.

## R CMD check results

There were no ERRORs or WARNINGs.
This is an update in response to Kurt Hornik's emails dated 2018-05-17 and 2018-06-18 re: packages with "undeclared package dependencies in their unit test code".

There is one NOTE. I have changed my email address from [email protected] to [email protected].
Previously googlesheets called `tibble::tibble()` in its tests, where tibble is an indirect dependency of googlesheets. Now I use `dplyr::data_frame()` instead. dplyr is a direct Import of googlesheets.

There is also this, which is not new and I am giving the same explanation:
## Test environments

Found the following (possibly) invalid URLs:
URL: https://console.developers.google.com
From: man/gs_auth.Rd
man/gs_webapp_auth_url.Rd
Status: 404
Message: Not Found

This URL goes to the Google Developers Console if and only if user is currently signed in with Google. Otherwise it redirects to a login screen. I assume something about that process is causing CRAN to think the URL is invalid.
* local OS X install, R 3.4.3 and R 3.5.0
* Ubuntu 14.04.5 LTS (trusty) via travis-ci, R 3.5
* Windows, R 3.4.4, 3.5.0, Under development (unstable) (2018-06-20 r74924) via win-builder

## Downstream dependencies
## R CMD check results

There aren't any.
There were no ERRORs or WARNINGs or NOTEs.

0 comments on commit b7ec744

Please sign in to comment.