[JENKINS-45534] Bug Remove External sites #10
Conversation
update Master
|
@tlenaic That's a good point, we'll add that into 2.0.0 but the codebase is changing so i won't merge anything yet. Same with thresholds, take a look at development-2.0.0-action branch, everything will be controlled by the ZAP class. That's why i haven't merged your changes for Thresholds yet since the Management class is using the older way of initializing zap. I'm trying to finish this asap :) Once i finish that change and merge it into development-2.0.0, i'll merge all other changes in as well. |
|
@tlenaic Can you please create a Jenkins JIRA ticket for the bug. I know it's a small issue but I'd like to have it documented regardless. |
|
Looking over this pull request during the week. Please squash the commits into one. |
when option unchecked, all external URL's still cleared. Not test, and i think there is not mistake minor correction remove an extra if condition Minors Bugs Correct when option unchecked, all external URL's still cleared. Not test, and i think there is not mistake minor correction remove an extra if condition
tlenaic
force-pushed
the
Bug-Remove-ExternalSites
branch
from
8c4761d
to
e9a2c73
Compare
tlenaic
changed the title
|
I am encountering the issue that this Pull Request seems to fix. Any chance of this getting merged and released? |
I notice a minor bug on "delete external sites" in the persistent session.
When the option is not enabled on the plugin, we should not delete all URLs, but in fact we still do. And finally the was a spelling issue.