Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure eslint for warnings-ng to report on CI #935

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

timja
Copy link
Member

@timja timja commented Sep 23, 2024

see jenkinsci/plugin-pom#874

Depends on jenkins-infra/pipeline-library#883 pipeline library to add:
https://github.com/jenkinsci/jenkins/blob/master/Jenkinsfile#L175C33-L179

and jenkinsci/plugin-pom#1016

Testing done

Introduced lint warnings locally with both CI and not CI.
Tested with PR of pipeline library showing that reporting is correct
Tested with SNAPSHOT of parent pom showing that new opt-in method works:

# -Dtest for a faster build, it still runs the frontend tests
mvn test -Dtest=org.jenkins_ci.plugins.workflow.workflow_cps.InjectedTest -Dmaven.test.failure.ignore

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja requested a review from a team as a code owner September 23, 2024 15:07
@timja timja marked this pull request as draft September 23, 2024 15:07
plugin/package.json Outdated Show resolved Hide resolved
plugin/pom.xml Outdated Show resolved Hide resolved
@timja
Copy link
Member Author

timja commented Oct 3, 2024

@jglick any thoughts on bumping to parent pom 5.0? Requires updating the minimum jenkins.version to 2.479.

@timja timja added the chore label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants