Skip to content

Commit

Permalink
[maven-release-plugin] prepare release winstone-6.19
Browse files Browse the repository at this point in the history
  • Loading branch information
@basil
basil committed May 3, 2024
1 parent 5a65223 commit 583f671
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</parent>

<artifactId>winstone</artifactId>
<version>${revision}${changelist}</version>
<version>6.19</version>
<packaging>jar</packaging>

<name>Winstone</name>
Expand Down Expand Up @@ -200,7 +200,7 @@
<connection>scm:git:https://github.com/${gitHubRepo}.git</connection>
<developerConnection>scm:git:[email protected]:${gitHubRepo}.git</developerConnection>
<url>https://github.com/${gitHubRepo}</url>
<tag>${scmTag}</tag>
<tag>winstone-6.19</tag>
</scm>

<dependencyManagement>
Expand Down

6 comments on commit 583f671

@olamy
Copy link
Member

@olamy olamy commented on 583f671 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil could you please sign tag as well? thanks

@basil
Copy link
Member Author

@basil basil commented on 583f671 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil could you please sign tag as well? thanks

I could, but I see no reason to do as you have requested.

@olamy
Copy link
Member

@olamy olamy commented on 583f671 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a good practice. probably even more important signing commits as this is what is delivered.
But anyway it's up to you.

@basil
Copy link
Member Author

@basil basil commented on 583f671 May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a good practice

I don't doubt that it is, but as of today it isn't common in the Jenkins community among people releasing plugins or core components manually (i.e., not with JEP-229). If we want to go in this direction, I think it would be a good idea to start a developer list thread about it and to update the developer documentation with instructions so that all developers can follow this best practice as they do manual releases.

@olamy
Copy link
Member

@olamy olamy commented on 583f671 May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just do not find it consistent to sign your commits but not for the release.
But As I said,

But anyway, it's up to you.

@basil
Copy link
Member Author

@basil basil commented on 583f671 May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't intentionally sign anything, but maybe GitHub signs them when I use the web interface to merge a PR. I don't know how to sign things that are committed manually and I don't think most Jenkins developers are doing this today, which is why I think you would have more luck convincing people to do what you want through a mailing list thread and documentation rather than leaving comments on already shipped releases for some particular component.

Please sign in to comment.