Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-53662] Add isRestartedStage() when condition #293

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abayer
Copy link
Member

@abayer abayer commented Oct 16, 2018

  • JENKINS issue(s):
  • Description:
    • This will only fire when the run was restarted from a stage, and we're currently checking whether to execute the stage with the same name as the restarted stage.
  • Documentation changes:
    • The new condition will need to be added to the docs.
  • Users/aliases to notify:
    • ...

This will only fire when the run was restarted from a stage, and we're
currently checking whether to execute the stage with the same name as
the restarted stage.
@abayer abayer added this to the 1.3.3 milestone Oct 16, 2018
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that based on the user's latest comment in the ticket, it seems like isRestartedStage wouldn't work for the use case they had in mind originally.

The code seems fine to me, but it does seem like this feature is a little awkward to use, since you have to split your stages into not-restarted and restarted versions, (or to avoid duplicating code if the stages are large, split them into not-restarted-setup, restarted-setup, and do-work), and then make sure to use the restarted version whenever you want to restart the pipeline.

@abayer
Copy link
Member Author

abayer commented Oct 23, 2018

Yeah, I'm probably going to table this and work on a more general way of providing information on the restarted build/stage as a whole, rather than just one part at a time.

@abayer
Copy link
Member Author

abayer commented Oct 23, 2018

Moving this to WIP to make sure I don't inadvertently merge it before I am sure of the right approach.

@abayer abayer modified the milestones: 1.3.3, 1.3.4 Nov 27, 2018
@bitwiseman
Copy link
Contributor

@abayer Any chance you can resolve the merge conflicts here? Should this remain open?

@jglick jglick marked this pull request as draft January 3, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants