-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-46028] Look up test result from target branch if building a pull request #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a pull request for the first time, we don't have any test results. However we can look up the target branch and use its test results as reference.
jglick
reviewed
Jan 13, 2023
src/main/java/org/jenkinsci/plugins/parallel_test_executor/TargetBranchPreviousBuildFinder.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right. Tested interactively I guess? The former PR had some test coverage but I do not remember much.
(There is a demo/
with a multibranch project, but not set up for GitHub or anything else with a “change target head” ~ base branch.)
src/main/java/org/jenkinsci/plugins/parallel_test_executor/TargetBranchPreviousBuildFinder.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Jan 13, 2023
src/main/java/org/jenkinsci/plugins/parallel_test_executor/TargetBranchPreviousBuildFinder.java
Outdated
Show resolved
Hide resolved
…e previous one * Build hyperlink formatting * Adjust unit test accordingly
Vlatombe
changed the title
Look up test result from target branch if building a multibranch project
Look up test result from target branch if building a pull request
Jan 16, 2023
Vlatombe
force-pushed
the
target-branch-finder
branch
from
January 17, 2023 08:49
12b97db
to
6451c6d
Compare
jglick
changed the title
Look up test result from target branch if building a pull request
[JENKINS-46028] Look up test result from target branch if building a pull request
Jan 17, 2023
Vlatombe
added a commit
to Vlatombe/parallel-test-executor-plugin
that referenced
this pull request
Jan 19, 2023
If one of the previous build is failed or still ongoing, then the loop would iterate always on the same build until it reaches NUMBER_OF_BUILDS_TO_SEARCH, skipping any further builds.
jglick
added a commit
that referenced
this pull request
Jan 19, 2023
[JENKINS-46028] Fix previous build resolution broken in #226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a pull request for the first time, we don't have any test results. However we can look up the target branch and use its test results as reference.
Updated the
demo
in #227 to include a gitea server for multibranch support. It can be used to verify the changes by initializing it, waiting for the first build on themain
branch to complete, then create a pull request usingcreate-pr.sh
.Relates to #26, #26 (review) probably still stands but feel way more complicated than it needs to be to fulfill the requirement in the context of this plugin.