Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74090] Remove unused checkUrl in TagAction/tagForm.jelly #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaroslavafenkin
Copy link

https://issues.jenkins.io/browse/JENKINS-74090

Testing done

There's no corresponding doCheckTag method in TagAction.java or parent classes, so this is dead code.

I've also patched the latest version of the plugin (commenting out a few lines that were throwing exceptions) so that TagAction is added to my builds. I visited tagBuild page and no request is sent when I modify the field that has the checkUrl. Nor any CSP violations are logged in console or CSP report page.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant